2008/8/19 Joe Neeman <[EMAIL PROTECTED]>: > On Tue, 2008-08-19 at 13:09 -0300, Han-Wen Nienhuys wrote: >> I'll try to have another look at it, but from what I recall, there >> were serious issues with the code (it still has a bunch of FIXME and >> commented out parts). If you want to have this patch in, you need to >> rework it so >> >> a. you understand it
I basically understand how it works, but you cannot expect me to speak fluent C++ by the end of the week :( >> b. it is correct (from coding perspective) As far as I can see, it has been much improved since Rune's first attempt (last November, IIRC)... I still suspect there might be an easier way to implement this feature without requiring additional pitchclass and Key_entry definitions (since the accidental engraving style I was requesting is mainly used in atonal music, without any key signature), but I (surprisingly) cannot figure any way to code it. > I've been having a look at dev/rune over the last week or so and I'm > pretty sure I can get a minimal version with the new accidental > functionality prepared in the next day or two (minus fancy stuff like > virtual smobs). When I've done this, I'll push to dev/jneeman and ping > you for testing (Valentin) and reviewing (Han-Wen). Then you will be my savior :-) Thanks a lot for having a look, you're totally the one I needed! Cheers, Valentin _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
