Neat!

http://codereview.appspot.com/181109/diff/17/21
File lily/context-scheme.cc (right):

http://codereview.appspot.com/181109/diff/17/21#newcode26
lily/context-scheme.cc:26: // TODO: naming - should use now?
I think ly:context-current-moment is clearer (although of course it
isn't consistent with the C++ name)

http://codereview.appspot.com/181109/diff/17/27
File lily/include/scheme-engraver.hh (right):

http://codereview.appspot.com/181109/diff/17/27#newcode78
lily/include/scheme-engraver.hh:78: // todo: must_be_last() support?
This comment seems obsolete...

http://codereview.appspot.com/181109/diff/17/32
File lily/translator-group.cc (right):

http://codereview.appspot.com/181109/diff/17/32#newcode166
lily/translator-group.cc:166: // TODO: softcode the typename?
Surely the names of all C++ translators are compiled in. Why would you
want to softcode it?

http://codereview.appspot.com/181109


_______________________________________________
lilypond-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to