I've uploaded a new patch set for review, but I still have some questions.
First, some questions for Joe Neeman: Joe, with commit 7d410b9 (from 2009-12-17), in NR 4.4.1 "Vertical spacing inside a system - Spacing between staves", you wrote: If unset, stretchability defaults to space - minimum-distance. But 4 months later, with commit d701703 (2010-04-20), in lily/spacing-basic.cc, you wrote: By default, the spring will have an inverse_stretch_strength of space+min_dist. Is this a contradiction? Could you confirm the default calculation of 'stretchability? (Unfortunately, I don't speak C/C++). Also, I rewrote the 'stretchability entry; can you double-check that there's nothing erroneous/misleading? Should I remove the +inf.0 bit? * * * * * * * * * * Joe Neeman wrote:
The springs are always attached to the (0, 0) coordinate relative to each staff or markup.
So then (correct me if I'm wrong) my patch here is completely correct except for one detail: the "reference point" of a title/markup, which could be aligned with reality with this diff: result, and no stretching or compressing is in effect. The -reference point of a title or markup is either its highest point -(for spaces above) or its lowest point (for spaces below). The +reference point of a title or markup is its highest point, and the reference point of a system is the middle line of the nearest * * * * * * * * * * Graham Percival wrote:
Please use @subsubheading for this kind of stuff.
Done. * * * * * * * * * * And Alexander, are there still things you'd like me to change after reading my rationale (re: "unobstructed", "meaningful [values]", etc.)? * * * * * * * * * * Otherwise, okay to push? - Mark http://codereview.appspot.com/2316042/ _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
