Your thoughts generally look good to me, but I'll need to see a patch before I can approve.
Thanks, Carl http://codereview.appspot.com/3743045/diff/1/Documentation/notation/expressive.itely File Documentation/notation/expressive.itely (right): http://codereview.appspot.com/3743045/diff/1/Documentation/notation/expressive.itely#newcode366 Documentation/notation/expressive.itely:366: Textual crescendo marks begin with @code{\cresc} On 2010/12/22 21:43:38, Keith wrote:
On 2010/12/22 04:31:23, Carl wrote: > We can even get shorter and simpler here, I resist, here, because I would need the text to know what to look for
in the
code. Plus, the new \cresc is a big deal, as it fills a long-felt
need. The text doesn't add anything, if the example is the right example. Here's my thought process when I look at the music, then up to the code: "Let's see, I have a crescendo starting at g and going to e, which has a mf. Let me look at the code. Ahh. g has \cresc after it, so \cresc must start a text crescendo. And the explicit dynamic must end a text crescendo. And then I have a text decrescendo going from f to e, where a hairpin starts. Ahh, that makes sense in the code. And then I have a \dim that goes from a, through the tie, ending before the rest. \! must end the text dimuendo." If the example is too complicated to understand easily, then instead of trying to explain the example, split it up into multiple examples, each of which only shows one thing. Just as a picture is worth a thousand words, a good LilyPond example is worth multiple paragraphs of text in the NR. http://codereview.appspot.com/3743045/diff/1/Documentation/notation/expressive.itely#newcode392 Documentation/notation/expressive.itely:392: Textual marks can also be produced by @code{\<} and @code{\>}: On 2010/12/22 21:43:38, Keith wrote:
On 2010/12/22 04:31:23, Carl wrote: > "Textual markings for dynamic changes can also replace hairpins,
although
> this usage is deprecated:"
Maybe I have understood incorrectly, but it seems to me that we want to move to strictly postfix dynamic indications, whether text or hairpin. The thread below indicates that we want to move that direction for 3.0. We might as well get it out in the open right now, IMO. http://thread.gmane.org/gmane.comp.gnu.lilypond.devel/20614 But I won't hold up approval of the patch until it's identified as deprecated.
Yes, 'replace' is the right verb. I do not know that \dimTextDim is deprecated, though -- mightily
inconvenient,
yes, but consistent with other syntax and not in the way of any future
plans, so
far as I have heard.
http://codereview.appspot.com/3743045/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel