LGTM Cheers, MS
http://codereview.appspot.com/4636081/diff/42001/lily/stem-tremolo.cc File lily/stem-tremolo.cc (right): http://codereview.appspot.com/4636081/diff/42001/lily/stem-tremolo.cc#newcode61 lily/stem-tremolo.cc:61: return scm_from_double ((Stem::duration_log (stem) >= 3 && get_grob_direction (stem) == DOWN && !(beam)) !beam http://codereview.appspot.com/4636081/diff/42001/lily/stem-tremolo.cc#newcode93 lily/stem-tremolo.cc:93: return ly_symbol2scm (((stemdir == UP && flag) || beam) ? "rectangle" : "beam-like"); return ly_symbol2scm (style != ly_symbol2scm ("constant") && ((stemdir == UP && flag) || beam) ? "rectangle" : "beam-like"); with proper indenting... http://codereview.appspot.com/4636081/diff/42001/scm/define-grobs.scm File scm/define-grobs.scm (right): http://codereview.appspot.com/4636081/diff/42001/scm/define-grobs.scm#newcode1944 scm/define-grobs.scm:1944: (X-extent . ,ly:stem-tremolo::width) For consistency's sake (I just went through this with flags), keep this as a style property and document the possible values in the Stem_tremolo docstring in stem-tremolo.cc (the part with ADD_INTERFACE). http://codereview.appspot.com/4636081/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
