Thanks for reviewing it. Regards, Julien
http://codereview.appspot.com/5553056/diff/1/python/book_snippets.py File python/book_snippets.py (left): http://codereview.appspot.com/5553056/diff/1/python/book_snippets.py#oldcode806 python/book_snippets.py:806: self.ext = os.path.splitext (os.path.basename (self.filename))[1] On 2012/01/21 23:54:36, Reinhold wrote:
Why are you removing a generic statement and hardcoding .ly above?
This will
break e.g. if you try to include a .ily file as a snippet!
It does not break. I tested it. This self.ext is used only in output, in links to the source file. The '.ly' is hardcoded elsewhere already, so that when you include a .ily, lilypond-book actually writes a lily-????.ly file for it, and this is what we link to. On the other hand leaving the current code in leads to broken links to a lily-????.ily file. http://codereview.appspot.com/5553056/diff/1/python/book_snippets.py File python/book_snippets.py (right): http://codereview.appspot.com/5553056/diff/1/python/book_snippets.py#newcode124 python/book_snippets.py:124: line-width = #(- line-width (* mm %(padding_mm)f) (* mm 1))''', On 2012/01/21 23:54:36, Reinhold wrote:
On 2012/01/21 19:14:15, Julien Rioux wrote: > This fixes the first problem by adjusting line-width directly where
it is
> defined.
Aren't there cases when neither LINE_WIDTH nor QUOTE is used?
Yes, that's the case for html-inline-no-option.html
In that case we don't subtract the padding...
Why would a padding be relevant when there is no specified line width? http://codereview.appspot.com/5553056/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
