On Thu, Apr 26, 2012 at 10:07:32AM +0200, David Kastrup wrote: > I am afraid that you overestimate what I have been doing. I've been > running test-patches and looking at pretty pictures.
You've done more than that; you occasionally say "this looks like a silly design" or "why not do XYZ instead". You say that quite often after patches are accepted and you're trying to work on that area of code, but you still catch some of those problems during the review. That's what I'm asking you to do. I'm not asking you to look at the pretty pictures; don't look at any patch until somebody has signed off on those pretty pictures. That was the whole point of Patchy, after all! I don't want to waste developers' time by looking at patches which have easily-found problems like regtest comparisons. But after that's done -- after a patch has passed Patchy and is on a countdown -- then please look at the patch, and ask yourself "if I had to fix a bug or add a feature to this part of the code base, would that change make my work easier or harder?". - Graham _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
