Reviewers: lemzwerg, Message: On 2012/10/09 05:04:50, lemzwerg wrote:
LGTM, without testing, and without really understanding the change.
However,
simplifications and generalizations are always a good thing.
http://codereview.appspot.com/6635050/diff/1/Documentation/de/notation/pitches.itely
File Documentation/de/notation/pitches.itely (right):
http://codereview.appspot.com/6635050/diff/1/Documentation/de/notation/pitches.itely#newcode1529
Documentation/de/notation/pitches.itely:1529: \accidentalStyle StaffGroup."voice" This looks strange. I don't expect double quotes after a dot. Any
better
representation possibility?
Agreed. _All_ of the following will work: \accidentalStyle "StaffGroup.voice" \accidentalStyle StaffGroup.voice \accidentalStyle "StaffGroup"."voice" whereas everything involving #"Staffgroup..." will _not_ work (only LilyPond strings autoconvert to symbols). I think I'd go for \accidentalStyle Staffgroup.piano-cautionary myself as then the temptation to employ Scheme strings by accident is smaller, but then it seems inconsistent to use \accidentalStyle "piano-cautionary" so I'd crank open another convert-ly rule to turn those into \accidentalStyle piano-cautionary as well. Which makes for worse backward-compatibility of scores. What do people prefer to see? Description: Make arguments like Context.GrobName accessible as symbol lists This is a rather awkward case for a Rietveld review since it consists of 14 separate commits (listed below). The principal target was to allow things like \omit Staff.TimeSignature to work as expected. The same treatment has been given to \alterBroken, \hide, \overrideProperty and \shape, as well as to \accidentalStyle. For improving backward compatibility, dotted _LilyPond_ strings like "Staff.TimeSignature" are also accepted in lieu of symbol list. A rather surprising corollary is that \override Lyrics.LyricText #'font-shape = #'italic now works without needing to offset . with spaces. While Lyrics.LyricText is indeed run into a single LilyPond string in this case, \override will happily pick that string apart again. LilyPond strings are also acceptable for symbol? predicates. The conversions will only be attempted if the string is not accepted by a predicate in the form of a string. Run scripts/auxiliar/update-with-convert-ly.sh convert-ly rule for \alterbroken, \accidentalStyle, \overrideProperty This is required since not all of the old call forms can be automatically recognized anymore, in particular not when the Scheme-only form #"Context.GrobName" is being used. Change \accidentalStyle to get a symbol list as argument Make \alterBroken, \hide, \omit, \overrideProperty, \shape take unquoted Context.Grob specs Add symbol-list-or-music? predicate Allow the string "xxx.yyy" to parse as a symbol list Allow property and grob paths to be constructed from strings Add symbol-list? predicate Allow LilyPond strings to stand in for symbols when parsing Let accidentalStyle detect its optional context argument by looking at its letter case Factor SCM_IDENTIFIER out from embedded_scm_arg* parser.yy: make is_regular_identifier match the lexer definition parser.yy: FRACTION does not require a closed expression before it Assignments can't contain literal lyric music (wrong lexer mode) Please review this at http://codereview.appspot.com/6635050/ Affected files: M Documentation/de/extending/programming-interface.itely M Documentation/de/notation/pitches.itely M Documentation/de/notation/spacing.itely M Documentation/es/extending/programming-interface.itely M Documentation/es/notation/pitches.itely M Documentation/es/notation/spacing.itely M Documentation/extending/programming-interface.itely M Documentation/fr/extending/programming-interface.itely M Documentation/fr/notation/pitches.itely M Documentation/fr/notation/spacing.itely M Documentation/it/notation/pitches.itely M Documentation/ja/notation/pitches.itely M Documentation/ja/notation/spacing.itely M Documentation/notation/pitches.itely M Documentation/notation/spacing.itely M Documentation/snippets/text-headword.ly M input/regression/alignment-vertical-manual-setting.ly M input/regression/alter-broken.ly M input/regression/page-layout-manual-position.ly M input/regression/page-spacing-bass-figures.ly M input/regression/page-spacing.ly M lily/parser.yy M ly/music-functions-init.ly M ly/property-init.ly M python/convertrules.py M scm/c++.scm M scm/lily.scm _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel