Reviewers: ,
Description:
Fix trill timing in articulate.ly
Used a fixed duration for the "twiddletime" instead of the broken
heuristic
that was used before.
Please review this at https://codereview.appspot.com/173750043/
Affected files (+3, -5 lines):
M ly/articulate.ly
Index: ly/articulate.ly
diff --git a/ly/articulate.ly b/ly/articulate.ly
index
6992c87ebdc94b8a7a09860153d7494655b8354a..6562f209d92e87bd002385f4640be5f8e937d2fe
100644
--- a/ly/articulate.ly
+++ b/ly/articulate.ly
@@ -347,13 +347,11 @@
(ly:music-property music 'elements)))
(pre-t (if (pair? tr) (ly:music-property (car tr) 'twiddle)
'()))
+ (hemisemidur (ly:make-duration 5 0 1/1))
(t (ac:targetTwiddleTime)))
(if (ly:moment? pre-t)
pre-t
- (let loop ((len (ly:music-length music)))
- (if (ly:moment<? t len)
- (loop (ly:moment-mul len (ly:make-moment 1/2)))
- len)))))
+ hemisemidur)))
@@ -367,7 +365,7 @@
(t (ac:twiddletime music))
(uppernote '())
(note_moment (ly:moment-mul t (ly:make-moment 1/2)))
- (c1 (ly:moment-div orig-len note_moment))
+ (c1 (ly:moment-div orig-len t))
(c2 (inexact->exact
(round (/ (ly:moment-main-numerator c1)
(* 2 (ly:moment-main-denominator c1))))))
_______________________________________________
lilypond-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
