LGTM, thanks. Only cosmetic nits :-)
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc File lily/line-spanner.cc (right): https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode395 lily/line-spanner.cc:395: "Sets the Y-coordinate of the end point, in staff-spaces" I think this should rather be Sets the y@tie{}coordinate..., in staff spaces. Ditto in other places. https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode398 lily/line-spanner.cc:398: " vertical center of the note head.\n" The final `\n' here (and in similar places) in the middle of a paragraph doesn't have any effect. texinfo simply slurps it. Only two `\n' in a row to indicate a paragraph end are honored. https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode404 lily/line-spanner.cc:404: " So, a value of -1 (or LEFT) makes the line start/end at" ... or @code{LEFT} ... https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode416 lily/line-spanner.cc:416: "@item stencil-offset\n" @itemx stencil-offset\n https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode418 lily/line-spanner.cc:418: " end-point, centered on the line, as defined by the X and" end point, ... by the @code{X} and @code{Y} ... https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode420 lily/line-spanner.cc:420: " stencil-offset will move the symbol at the edge vertically" Setting either @code{...} or @code{...} https://codereview.appspot.com/560670043/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
