https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc
File lily/line-spanner.cc (right):
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode395
lily/line-spanner.cc:395: "Sets the Y-coordinate of the end point, in
staff-spaces"
On 2019/05/10 10:33:12, dak wrote:
On 2019/05/10 05:22:32, lemzwerg wrote:
> I think this should rather be
>
> Sets the y@tie{}coordinate..., in staff spaces.
>
> Ditto in other places.
I think I'd at least stick with uppercase since it evokes the #X and
'X-offset
and other programmatic use of X inside of LilyPond. Other than that,
agree.
Y@tie{}coordinate etc is used now, here and in other places.
Done.
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode398
lily/line-spanner.cc:398: " vertical center of the note head.\n"
On 2019/05/10 05:22:31, lemzwerg wrote:
The final `\n' here (and in similar places) in the middle of a
paragraph doesn't
have any effect. texinfo simply slurps it. Only two `\n' in a row to
indicate
a paragraph end are honored.
It was built after slur.cc. Thus I guess many `\n' there could be
deleted as well.
Corrected here.
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode404
lily/line-spanner.cc:404: " So, a value of -1 (or LEFT) makes the line
start/end at"
On 2019/05/10 05:22:32, lemzwerg wrote:
... or @code{LEFT} ...
Done.
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode416
lily/line-spanner.cc:416: "@item stencil-offset\n"
On 2019/05/10 05:22:32, lemzwerg wrote:
@itemx stencil-offset\n
I didn't know about @itemx.
Done.
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode418
lily/line-spanner.cc:418: " end-point, centered on the line, as defined
by the X and"
On 2019/05/10 05:22:32, lemzwerg wrote:
end point, ... by the @code{X} and @code{Y} ...
Done.
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode420
lily/line-spanner.cc:420: " stencil-offset will move the symbol at the
edge vertically"
On 2019/05/10 05:22:31, lemzwerg wrote:
Setting either @code{...} or @code{...}
Done.
https://codereview.appspot.com/560670043/
_______________________________________________
lilypond-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
