Dan, I would certainly not want that such a typo is not corrected at all. You may take the decision, whether you push it to staging just alone (which I should prefer) or you keep it in the patchset attached to Issue 5639
> -----Oorspronkelijk bericht----- > Van: [email protected] <[email protected]> > Verzonden: Monday, December 16, 2019 1:24 AM > Aan: [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected] > CC: [email protected]; [email protected] > Onderwerp: Re: Issue 5639: compile with -std=c++11 (issue 553310045 by > [email protected]) > > On 2019/12/15 14:40:08, dan_faithful.be wrote: > > On Dec 15, 2019, at 06:31, mailto:[email protected] wrote: > > > It is not the commit title, but I do think that this is not a part > of issue > > 5639: compile with --std=c11 > > > The reason that I think it is important to keep this separated is > that the > > impact is very different. > > > When a commit with only comments is in a separate issue, it is easy > to cherry > > pick it for let say version 2.0. > > > Although you make it a separate commit, in rietveld it is still one > issue. > > > The effort of handling a separate ticket and review is not worth it to > me for > > this particular typo correction. I'm willing to revert it and leave > it for the > > next person who notices it, if that bothers you less than piggybacking > on this > > issue. > > — > > Dan > > > Dan, a typo in a comment or in a doc string _not_ passed through Texinfo or > not containing Texinfo-relevant changes is material for just pushing to > staging > in a commit of its own. As you say, review is overkill, and wrapping it into > some other topic not touching a file is a distraction. > > https://codereview.appspot.com/553310045/
