Reviewers: hanwenn,
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py File python/musicexp.py (right): https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py#newcode375 python/musicexp.py:375: "portugues": pitch_portugues, On 2020/02/15 12:19:54, hanwenn wrote: > português I don't think it makes sense to use anything here that doesn't match the notename language defined in scm/define-note-names.scm . There is not even an alias português there. Description: musicxml2ly: portugues notenames and quarternotes in español Given by Torsten Hämmerle after issue 5746 ended. Please review this at https://codereview.appspot.com/571630043/ Affected files (+7, -2 lines): M python/musicexp.py Index: python/musicexp.py diff --git a/python/musicexp.py b/python/musicexp.py index 8e3bde379312f570d79ba12b7ec7692eec6764f9..d6d5b6fa56e32cbda1fadc09c51e50ed9035c606 100644 --- a/python/musicexp.py +++ b/python/musicexp.py @@ -348,8 +348,12 @@ def pitch_francais (pitch): return str def pitch_espanol (pitch): - str = pitch_generic (pitch, ['do', 're', 'mi', 'fa', 'sol', 'la', 'si'], ['b', None, None, 's']) - return str + str = pitch_generic (pitch, ['do', 're', 'mi', 'fa', 'sol', 'la', 'si'], ['b', 'cb', 'cs', 's']) + return str.replace ('bc', 'tc').replace ('sc', 'tc') + +def pitch_portugues (pitch): + str = pitch_generic (pitch, ['do', 're', 'mi', 'fa', 'sol', 'la', 'si'], ['b', 'bqt', 'sqt', 's']) + return str.replace ('bbqt', 'btqt').replace ('ssqt', 'stqt') def pitch_vlaams (pitch): str = pitch_generic (pitch, ['do', 're', 'mi', 'fa', 'sol', 'la', 'si'], ['b', None, None, 'k']) @@ -368,6 +372,7 @@ def set_pitch_language (language): "catalan": pitch_catalan, "espanol": pitch_espanol, "español": pitch_espanol, + "portugues": pitch_portugues, "vlaams": pitch_vlaams} pitch_generating_function = function_dict.get (language, pitch_general)
