On 2020/02/15 16:58:45, hanwenn wrote: > https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py > File python/musicexp.py (right): > > https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py#newcode364 > python/musicexp.py:364: function_dict = { > I meant something like > > # this map should be synchronized with scm/define-note-names.scm
Hello, I'd propose to leave it as it is for this patch. But apart from that, I also dislike LilyPond's inconsistent language naming conventions. I've prepared a patch finally introducing full quarter tone support for all languages and this also includes a complete set of fully tested MusicMXL pitch import rules. And it's about proper language spelling introducing català and português. I've dropped a mail in the dev list asking for opinions about consistent language naming conventions. In any case, I'll wait with my patch until this one has been pushed. All the best, Torsten https://codereview.appspot.com/571630043/
