Reviewers: lemzwerg, Message: On 2020/03/22 05:51:34, lemzwerg wrote: > LGTM > > https://codereview.appspot.com/547810069/diff/575870045/GNUmakefile.in > File GNUmakefile.in (right): > > https://codereview.appspot.com/547810069/diff/575870045/GNUmakefile.in#newcode26 > GNUmakefile.in:26: RELEASE_FILES = RELEASE-COMMIT > Many GNU packages auto-generate a ChangeLog file from the git commit messages. > Shall we do something similar?
What is the ChangeLog used for these days? Many GNU packages haven't been with the times. Git is now 14 years old. I people want to know what changed, they can read the man page to git-log. Description: Trim unused toplevel targets. Please review this at https://codereview.appspot.com/547810069/ Affected files (+3, -15 lines): M GNUmakefile.in Index: GNUmakefile.in diff --git a/GNUmakefile.in b/GNUmakefile.in index 42b62683302441b1fbcb14a8b0a8433397e86d4d..850bd8b5f0d3e4b37cb8b9977c10da369c0f2c53 100644 --- a/GNUmakefile.in +++ b/GNUmakefile.in @@ -23,7 +23,7 @@ TOPDOC_FILES = AUTHORS INSTALL README NEWS TOPDOC_TXT_FILES = $(addprefix $(top-build-dir)/Documentation/topdocs/$(outdir)/,$(addsuffix .txt,$(TOPDOC_FILES))) IN_FILES := $(call src-wildcard,*.in) -RELEASE_FILES = ChangeLog RELEASE-COMMIT +RELEASE_FILES = RELEASE-COMMIT RELEASE_OUT_FILES = $(RELEASE_FILES:%=$(outdir)/%) OUT_DIST_FILES += $(RELEASE_OUT_FILES) INSTALLATION_DIR=$(local_lilypond_datadir) @@ -78,15 +78,10 @@ $(outdir)/VERSION: $(config_make) VERSION -mkdir -p $(outdir) echo $(TOPLEVEL_VERSION) > $@ -$(outdir)/ChangeLog: $(outdir)/VERSION - $(call ly_progress,Making,$@,) - @echo 'See http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=log;h=refs/tags/release/$(TOPLEVEL_VERSION)-1' > $@ - -$(outdir)/RELEASE-COMMIT: # FIXME: any file in $(top-src-dir)/.git/ we can depend on and be sure RELEASE-COMMIT is up to date? +$(outdir)/RELEASE-COMMIT: $(call ly_progress,Making,$@,) git --git-dir=$(top-src-dir)/.git show HEAD | head -100 > $@ -# junk me as soon as RELEASE-COMMIT FIXME: has been addressed refresh-release-files: test -d $(top-src-dir)/.git && rm -f $(RELEASE_OUT_FILES) $(MAKE) $(RELEASE_OUT_FILES) @@ -97,10 +92,7 @@ python-modules: top-doc: python-modules -local-clean: local-clean-ChangeLog local-clean-filelist - -local-clean-ChangeLog: - rm -f ChangeLog +local-clean: local-clean-filelist info: $(foreach d, $(INFO_DIRECTORIES),$(MAKE) -C $(d) out=www info && ) true @@ -195,10 +187,6 @@ tree-share = $(tree-prefix)/share tree-share-prefix = $(tree-share)/lilypond/current tree-lib-prefix = $(tree-lib)/lilypond/current -C_DIRS = flower lily -c-clean: - $(foreach i, $(C_DIRS), $(MAKE) -C $(i) clean &&) true - src-ext = c cc yy ll hh icc py scm tex ps texi itexi tely itely sh doc-clean: snippets-clean $(tree-share-prefix)/lilypond-force