https://codereview.appspot.com/577840053/diff/561760044/lily/lily-lexer.cc
File lily/lily-lexer.cc (right):

https://codereview.appspot.com/577840053/diff/561760044/lily/lily-lexer.cc#newcode97
lily/lily-lexer.cc:97: Protected_scm Lily_lexer::keytable_;
could move out of Lily_lexer.

https://codereview.appspot.com/577840053/diff/561760044/lily/lily-lexer.cc#newcode102
lily/lily-lexer.cc:102: if (!keytable_.is_bound ())
move this to a global init function? There is no reason to this in the
constructor.

https://codereview.appspot.com/577840053/diff/561760044/lily/lily-lexer.cc#newcode202
lily/lily-lexer.cc:202: Lily_lexer::keyword_list () const
Can you drop "ly:lexer-keywords" and delete this function?

https://codereview.appspot.com/577840053/

Reply via email to