On 2020/04/27 22:07:07, dak wrote: > https://codereview.appspot.com/577840053/diff/561760044/lily/lily-lexer.cc > File lily/lily-lexer.cc (right): > > https://codereview.appspot.com/577840053/diff/561760044/lily/lily-lexer.cc#newcode97 > lily/lily-lexer.cc:97: Protected_scm Lily_lexer::keytable_; > On 2020/04/27 21:22:59, hanwenn wrote: > > could move out of Lily_lexer. > > It's only used in there and changing it elsewhere would be really bad, so why?
I was about to say this. And as it stands, it is obviously initialized before it is used. As a global, who knows? I wouldn't spend any time trying to find another way. https://codereview.appspot.com/577840053/
