On Sun, May 17, 2020 at 3:22 PM David Kastrup <[email protected]> wrote: > > for posterity, it is usually easier to put all info inside the commit > > message, because it doesn't rely on external sites (rietveld, > > sourceforge, gitlab). We need the MRs to discuss the code and commit > > message. What benefit do we get from also having an issue? > > The merge requests are not referenceable in the same manner as issues > are. We have carried over our issue numbers but not the Rietveld > numbers. So the link from commit message to merge request is just not > there: a merge request does not really fill more of a need than Rietveld > did previously. > > The commit message is not, in my book, the right place to carry an > adversarial discussion. Rather it's the place for the conclusion. > Circumstances may change invalidating the conclusion: without the > possibility to refer back to the previous discussion, understanding the > premises under which a conclusion has been drawn is not possible. > > We want to avoid developers stomping over the efforts of other > developers unwittingly because they were not able to look up the > discussions leading to a certain outcome.
So, how about we add the MR URL to the commit message? That provides an easy pointer to the discussion if that is needed afterwards. -- Han-Wen Nienhuys - [email protected] - http://www.xs4all.nl/~hanwen
