Al,
I just noticed you're cleaning up a bunch of fs code in ELKS.
I have been reviewing the original linux sources, and I think I've noticed an
error in the #ifdef BLOAT_FS stuff in ELKS.
The problem is in elks/fs/buffer.c, 22 lines into the function getblk().
There is a comment made by the person creating the BLOAT_FS stuff, and he
#ifdef'd out the a repeated find_buffer call, saying he thought it was redundant.
Well, Linus says in his 0.01 kernel in the same function:
/* NOTE!! while we slept waiting for this block, someone else might
already have added this block to the cache, check it */
I think this is a bug, and could cause a major buffers bug if
ELKS ever ran multiple tasks that read and wrote the same buffer. I suggest
we uncomment it out and leave it in. There's really no harm in leaving it there,
considering the comment when commenting it out:
/* I think the following check is redundant so I will remove it for now*/
Greg
