On Sun, Dec 05, 1999 at 09:04:17PM +0100, Andrea Arcangeli wrote:
> pcibios_assign_special _only_ deals with pci base address. Without the
> quirk added in the pci_fixup_irq stuff all the irqs of the contaq gets set
> to 0 here.
Yeah. Wanna know why? It's because dp264_map_irq isn't quite right,
and says there's no mapping for the slot/pin the contaq is on.
Figure out how to get docs out of Digital or reverse engineer the
appropriate numbers and fix the real problem.
> ____cacheline_aligned make sure that the struct is large a multiple of
> 32bytes.
>
> __cacheline_aligned make sure the struct will start in an aligned
> boundary.
No, ____cacheline_aligned does both. The alignment for a structure
is of necessity at least as large as the alignment of any of its
members. And __cacheline_aligned, since it does include the aligned
attribute, also pads the size of the structure.
The whole separate section thing is completely unnecessary, since
ELF can represent the required alignment of data objects. But
it could potentially result in slightly better packing of data,
so there's no reason to remove it.
r~
