On Wed, 2005-01-26 at 15:25 -0800, David S. Miller wrote:
>
> It will warn like this:
>
> foo.c:7:6: missing binary operator before token "("
> foo.c:10:32: missing binary operator before token "("
>
> Which looks exactly like the kind of warnings mm/memory.c was
> producing for me on sparc64.
>
OK you're right.
> Let's just face it that this is not a compile time test in
> any way. We could make it so by creating some kind of
> PTRS_PER_PMD_MIGHT_BE_GREATER_THAN_ONE macro platforms can
> define but this is getting really rediculious :-)
Well I'd say just don't worry about the runtime test either.
It is only a small amount of dead code on PTRS_PER_XXX == 1
architectures, and a special enough case that I think that is
OK.
So I'd say just remove the check entirely. If someone really
cares, they can do the crazy macro!
