On Mon, Feb 07, 2005 at 11:28:37AM -0800, David S. Miller wrote: > On Mon, 7 Feb 2005 09:11:06 +0100 > Andi Kleen <[EMAIL PROTECTED]> wrote: > > > Also BTW your proposed check wouldn't catch all cases anyways, > > it would only handle the case where the access_ok() check is > > done inside the KERNEL_DS. > > There must be a verify area done (either via explicit call or > via the user access macros which do not have the "__" prefix) > for each range of "userspace" accesses done through the uaccess.h accessors.
Yes, but it is done outside KERNEL_DS (otherwise it is a security hole) And then later in KERNEL_DS there is no verify_area. So this change wouldn't help you at all because it would rarely if ever catch any bugs. -Andi
