On Mon, Mar 07, 2011 at 10:09:48PM -0800, [email protected] wrote: > + mpp_chip->gpio_chip.label = PM8XXX_MPP_DEV_NAME; > + mpp_chip->gpio_chip.direction_input = pm8xxx_mpp_dir_input; > + mpp_chip->gpio_chip.direction_output = pm8xxx_mpp_dir_output; > + mpp_chip->gpio_chip.to_irq = pm8xxx_mpp_to_irq; > + mpp_chip->gpio_chip.get = pm8xxx_mpp_get; > + mpp_chip->gpio_chip.set = pm8xxx_mpp_set; > + mpp_chip->gpio_chip.dbg_show = pm8xxx_mpp_dbg_show; > + mpp_chip->gpio_chip.ngpio = pdata->core_data.nmpps; > + mpp_chip->gpio_chip.can_sleep = 1; > + mpp_chip->gpio_chip.dev = &pdev->dev; > + mpp_chip->gpio_chip.base = pdata->mpp_base;
It's seems really odd that you're adding gpiolib stuff here when you've also got a separate gpiolib driver. Possibly this all shouldn't actually be split up as much as it is - there's also the issue with the gpiolib driver needing to peer into the interrupt controller. It might simplify the code if things were merged more. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
