On Sat, 2025-06-07 at 07:12 -0700, Dave Hansen wrote: [...] > James, by partial revert, did you mean to revert in stable but not > mainline? I assumed you meant to just revert patch 6/6 of the series > (stable and mainline) but leave 1-5 in place so turning it back on > later was easier.
No, we had to put the revert through mainline because too many people who build their own kernels use the firmware service. We definitely didn't revert the entire series. I constructed a new patch which was effectively a partial revert only of the behaviour that was tickling the bug. For the record, this was the series containing the problem: https://lore.kernel.org/all/[email protected]/ And this is the revert we eventually came up with: https://lore.kernel.org/all/63837c36eceaf8cf2af7933dccca54ff4dd9f30d.ca...@hansenpartnership.com/ So it was specifically not a general revert but a narrowly crafted one to get firmware services working again. The mechanism we did was to queue the revert as an -rc fix so it went in immediately and got backported to stable and then queue the revert of the revert for the next merge window (and check before sending to Linus that the user space update had spread far enough otherwise we'd have skipped to the merge window after). Regards, James
