Hi Sagi, I love your patch! Yet something to improve:
[auto build test ERROR on v4.15] [also build test ERROR on next-20180206] [cannot apply to linus/master rdma/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sagi-Grimberg/irq-am-Introduce-library-implementing-generic-adaptive-moderation/20180206-224501 config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sh All error/warnings (new ones prefixed by >>): >> lib/irq-am.c:17:8: error: type defaults to 'int' in declaration of >> 'DEFINE_IDA' [-Werror=implicit-int] static DEFINE_IDA(am_ida); ^~~~~~~~~~ >> lib/irq-am.c:17:1: warning: parameter names (without types) in function >> declaration static DEFINE_IDA(am_ida); ^~~~~~ lib/irq-am.c: In function 'irq_am_cleanup': >> lib/irq-am.c:262:2: error: implicit declaration of function >> 'ida_simple_remove'; did you mean 'simple_rename'? >> [-Werror=implicit-function-declaration] ida_simple_remove(&am_ida, am->id); ^~~~~~~~~~~~~~~~~ simple_rename >> lib/irq-am.c:262:21: error: 'am_ida' undeclared (first use in this function) ida_simple_remove(&am_ida, am->id); ^~~~~~ lib/irq-am.c:262:21: note: each undeclared identifier is reported only once for each function it appears in lib/irq-am.c: In function 'irq_am_init': >> lib/irq-am.c:276:11: error: implicit declaration of function >> 'ida_simple_get'; did you mean 'simple_open'? >> [-Werror=implicit-function-declaration] am->id = ida_simple_get(&am_ida, 0, 0, GFP_KERNEL); ^~~~~~~~~~~~~~ simple_open lib/irq-am.c:276:27: error: 'am_ida' undeclared (first use in this function) am->id = ida_simple_get(&am_ida, 0, 0, GFP_KERNEL); ^~~~~~ lib/irq-am.c: At top level: lib/irq-am.c:17:8: warning: 'DEFINE_IDA' declared 'static' but never defined [-Wunused-function] static DEFINE_IDA(am_ida); ^~~~~~~~~~ cc1: some warnings being treated as errors vim +17 lib/irq-am.c 16 > 17 static DEFINE_IDA(am_ida); 18 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
