On Tue, 2018-02-06 at 00:03 +0200, Sagi Grimberg wrote:
> +void irq_poll_init_am(struct irq_poll *iop, unsigned int nr_events,
> +        unsigned short nr_levels, unsigned short start_level, irq_poll_am_fn 
> *amfn)
> +{
> +     iop->amfn = amfn;
> +     irq_am_init(&iop->am, nr_events, nr_levels, start_level, irq_poll_am);
> +}

This function has a large number of parameters and most of them are passed 
verbatim to
irq_am_init(). Please consider to introduce a structure for these parameters 
such that
the number of function arguments stays reasonable.

Thanks,

Bart.



Reply via email to