On Tue, Apr 24, 2018 at 04:04:22PM -0600, Johannes Thumshirn wrote:
> On Tue, Apr 24, 2018 at 03:41:46PM -0600, Keith Busch wrote:
>
> [...]
>
> > +DESCRIPTION="break PCI link while doing I/O"
> > +TIMED=1
>
> I _think_ we can set QUICK=1 here, Omar?
>
> > +
> > +requires() {
> > + _have_fio
> > +}
>
> You're using setpci below, so please add it to requires,
> i.e. _have_fio && _have_program setpci
>
> > +
> > +device_requires() {
> > + _test_dev_is_pci
> > + _test_hotplug_slot
> > +}
>
> I think this sould be _test_dev_is_pci && _test_hotplug_slot
Sounds good. Thanks for the feedback!
