On Fri, 2018-05-11 at 14:35 +0200, Christoph Hellwig wrote:
> > It should be due to union blk_deadline_and_state.
> > +union blk_deadline_and_state {
> > + struct {
> > + uint32_t generation:30;
> > + uint32_t state:2;
> > + uint32_t deadline;
> > + };
> > + unsigned long legacy_deadline;
> > + uint64_t das;
> > +};
>
> Yikes. Or we just move it into a separate field. This patch already
> shrinks struct request a lot, so I'd rather do that to keep it simple.
Hello Christoph,
Are you perhaps referring to the legacy_deadline field? Have you noticed that
Jianchao used a legacy block layer function in blk-mq code and that that is
why a wrong value for the deadline appeared in the trace output?
Thanks,
Bart.
