On Thu, 2018-08-09 at 10:52 +0800, Ming Lei wrote: > On Wed, Aug 08, 2018 at 05:28:43PM +0000, Bart Van Assche wrote: > > Some but not all blk_queue_enter() calls are related to request allocation > > so > > The only one I remember is scsi_ioctl_reset(), in which scsi_autopm_get_host() > is called before allocating this request, that means it is enough to put > host up for handling RESET. Also this request shouldn't have entered the block > request queue. > > Or are there other cases in which request allocation isn't related with > blk_queue_enter()?
What I was referring to in my e-mail is the q_usage_counter manipulations in blk_mq_timeout_work(). However, blk_mq_timeout_work() manipulates that counter directly. So it's only the blk_queue_exit() call in that function that is not related to request allocation. All blk_queue_enter() calls I know of are related to request allocation. Bart.
