On Mon, Mar 11, 2013 at 11:20:15AM +0100, Swâmi Petaramesh wrote: > Le 11/03/2013 07:47, Liu Bo a écrit : > > A recent commit(commit fa6ac8765c48a06dfed914e8c8c3a903f9d313a0 > > Btrfs: fix cleaner thread not working with inode cache option) > > may improve the situation. > > Hi Liu, > > I have never seen this issue with btrfs-cleaner not working, when I > delete snapshots it typically kicks in a few seconds later and works > "until done". >
The 'not working' is a little confused, sorry. It means that cleaner thread does not do its work in time. When we delete a snapshot/subvolume, we a)invalidate all of inodes that belong to it and then b)add it to a list for cleaner thread to do the real work if the last inode is destroyed from memory. What the commit tries to fix is that the inode cache inode will remain in memory so that keeps the snapshot/subvolume from adding to the cleanup list. And this'd result in the situation that our space is not freed as we wish. So back to the thread, if you notice that even cleaner thread does not help you get free space after you've delete the snapshot/subvolume, there should be some inodes of snapshot/subvolume remaining in memory. > Does the bug you mention affect only specific kernel versions ? After we have inode cache. > > AFAIK I use inode_cache (it's not in my fstab but I mounted my FSes > using it manually, and I believe it's a "persistent" option ? - I may > possibly be wrong...) It's only working when you mount with it, it helps you reuse inode id. thanks, liubo -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
