On Thu, Nov 15, 2018 at 01:23:25PM +0800, Qu Wenruo wrote: > > > On 2018/11/15 上午3:05, David Sterba wrote: > > On Tue, Nov 13, 2018 at 05:58:14PM +0000, Filipe Manana wrote: > >> That's the infinite loop issue fixed by one of the patches submitted > >> for 4.20-rc2: > >> > >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v4.20-rc2&id=11023d3f5fdf89bba5e1142127701ca6e6014587 > >> > >> The branch you used for testing doesn't have that fix? > > > > That explains it, thanks. The branch was based on 4.20-rc1 as I took it > > from Qu's repository but did not check the base. > > BTW should I always rebase my patches to misc-next or misc-4.20?
The misc-next can rebase as I add the tags or need to remove a patch etc., so using last rc or the last pulled branch (ie. the exact commit from misc-4.20, not the head itself) should be better option for you so you don't need to catch up and rebase constantly. I can handle rebases of your branches to current misc-next as long as there are no major conflicts. > IMHO based on -rc tags should make it easier for David to rebase/apply, > but if it's causing problem like this, I could definitely go misc-* based. No, that was my fault. I review and rebase all topic branches at each rc release, but taking the branch from your repo was a bit different step in the workflow.
