On Thu, Mar 11, 2021 at 11:25 AM Josef Bacik <jo...@toxicpanda.com> wrote:
>
> Hello,
>
> My recent debugging session with Neal's broken filesystem uncovered a glaring
> hole in my rescue=all patches, they don't deal with a NULL dev_root properly.
> In testing I only ever tested corrupting the extent tree or the csum tree, 
> since
> those are the most problematic.  The following 3 fixes allowed Neal to get
> rescue=all working without panicing the machine, and I verified everything by
> using btrfs-corrupt-block to corrupt a dev root of a file system.  Thanks,
>
> Josef
>
> Josef Bacik (3):
>   btrfs: init devices always
>   btrfs: do not init dev stats if we have no dev_root
>   btrfs: don't init dev replace for bad dev root
>
>  fs/btrfs/dev-replace.c | 3 +++
>  fs/btrfs/disk-io.c     | 2 +-
>  fs/btrfs/volumes.c     | 3 +++
>  3 files changed, 7 insertions(+), 1 deletion(-)
>
> --
> 2.26.2
>

I'm very happy that my freak disk controller issue yielded some good
fixes for Btrfs rescue mode code. :)

Reviewed-by: Neal Gompa <ngomp...@gmail.com>


-- 
真実はいつも一つ!/ Always, there's only one truth!

Reply via email to