On Wed, Apr 14, 2021 at 2:00 PM Johannes Thumshirn
<johannes.thumsh...@wdc.com> wrote:
>
> On 14/04/2021 13:23, Johannes Thumshirn wrote:
> > From how I understand the code, yes. It's a quick test, so let's just do it
> > and see what breaks.
> >
> > I'd prefer to just drop the ->ro check, it's less special casing for zoned
> > btrfs that we have to keep in mind when changing things.
>
> OK, no this doesn't work, because btrfs_start_trans_remove_block_group() has
> this ASSERT(em && em->start == chunk_offset);, but btrfs_remove_block_group()
> from relocation has already called remove_extent_mapping().

Ah bummer.
Well your previous proposal is reasonable.

Thanks for checking it.

>


-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”

Reply via email to