On Sun, Jan 15, 2006 at 01:59:53PM +0300, Evgeniy Polyakov wrote:
> 
> Are you sure sed and awk are good for kernel?
> Above string parsing eventually will end up in tricky bugs.
> What about following:
> 
> tfm = crypto_tfm_alloc("deflate", flags);
> err = tfm->setup(&user_provided_deflate_parameters);
> 
> int deflate_setup(void *data)
> {
>       struct deflate_setup *s = data;
> 
>       ... setup compression parameters from user's structure ...
> 
>       return 0;
> }

Passing void * pointers like this is going to cause even more bugs,
especially if you do it from user space to kernel space.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to