On Wed, 12 Nov 2008 18:33:59 -0600 Kim Phillips <[EMAIL PROTECTED]> wrote:
> On Fri, 07 Nov 2008 14:30:47 -0800 > James Hsiao <[EMAIL PROTECTED]> wrote: > > + * Changes: > > + * James Hsiao: 10/04/08 > > + * replace global variable lsec_core with data in > > + * in struct device. > > + * add parameter to various functions due to > > + * to remove of global variable lsec_core > > + * crypto4xx_alloc_sa now return error code. > > + * not using PVR to identify which CPU, using DTS. > > + * move this into the probe function. > > + * pass struct device pointer to dma_alloc_coherent > > + * and dma_free_coherent functions. > > + * make function static where ever is possible. > > + * remove crypto4xx_start_device. > > + * remove crypt4xx_setup_crypto. > > + * in crypto4xx_crypt_remove add kill tasklet. > > + * in crypto4xx_stop_all unmap ce_base and free core_dev. > > + * add lock to all get/put pd/sd/gd functions. > > + * change PPC4XX_SEC_VERSION_STR to "0.3" > > no changes list please. If you want to do a changelog for the patch itself to describe the differences between patch v2 and v3 and so-on, that is fine and actually very helpful to reviewers. Just do it after the commit log of the patch, but outside of the actual patch itself. > ..this is the type of reason why linuxppc-dev must be cc'd on this > patch; one is supposed to dynamically allocate and populate the > descriptor for the h/w, then grab the queue lock, quickly instruct the > h/w where to find it, and then immediately release it. This is covered > in the Linux Device Drivers book, and further details can be found under > Documentation/, see e.g. spinlocks.txt. > > I recommend you seek to get Josh Boyer's (amcc maintainer) acceptance > of this patch. Fixing the things Kim highlighted would be a good start. And please CC me, or at least linuxppc-dev, on future revisions. josh -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
