On Tue, Jul 21, 2009 at 11:02:17AM +0200, Steffen Klassert wrote:
>
> +     err = crypto_ahash_finup(ahreq);
> +     if (err == -EINPROGRESS)
> +             return;

This is redundant.  All completion functions must expect to be
called with EINPROGRESS followed by the actual completion later.

The same probably applies to other EINPROGRESS checks in this patch.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to