Hello

I have some minor comments below

> +config HW_RANDOM_MESON
> +     tristate "Amlogic Meson Random Number Generator support"
> +     depends on HW_RANDOM && ARCH_MESON

Perhaps you could change to:
depends on HW_RANDOM
depends on ARCH_MESON || COMPILE_TEST

> +
> +static int meson_rng_read(struct hwrng *rng, void *buf, size_t max, bool 
> wait)
> +{
> +     struct meson_rng_data *data =
> +                     container_of(rng, struct meson_rng_data, rng);
> +
> +     *(u32 *)buf = readl_relaxed(data->base + RNG_DATA);
> +
> +     return sizeof(u32);
> +}

I think you need a test for max < sizeof(u32)

Regards

LABBE Corentin
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to