Hi Atul,

Thank you for the patch! Yet we hit a small issue.
[auto build test ERROR on net-next/master]

url:    
https://github.com/0day-ci/linux/commits/Atul-Gupta/cxgb4-Add-support-for-Inline-IPSec-Tx/20171029-060344
config: x86_64-kexec (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/net//ethernet/chelsio/cxgb4/sge.c: In function 't4_eth_xmit':
>> drivers/net//ethernet/chelsio/cxgb4/sge.c:1198:6: error: implicit 
>> declaration of function 'xfrm_offload' 
>> [-Werror=implicit-function-declaration]
     if (xfrm_offload(skb) && !ssi->gso_size)
         ^~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/xfrm_offload +1198 drivers/net//ethernet/chelsio/cxgb4/sge.c

  1177  
  1178          /*
  1179           * The chip min packet length is 10 octets but play safe and 
reject
  1180           * anything shorter than an Ethernet header.
  1181           */
  1182          if (unlikely(skb->len < ETH_HLEN)) {
  1183  out_free:       dev_kfree_skb_any(skb);
  1184                  return NETDEV_TX_OK;
  1185          }
  1186  
  1187          /* Discard the packet if the length is greater than mtu */
  1188          max_pkt_len = ETH_HLEN + dev->mtu;
  1189          if (skb_vlan_tagged(skb))
  1190                  max_pkt_len += VLAN_HLEN;
  1191          if (!skb_shinfo(skb)->gso_size && (unlikely(skb->len > 
max_pkt_len)))
  1192                  goto out_free;
  1193  
  1194          pi = netdev_priv(dev);
  1195          adap = pi->adapter;
  1196          ssi = skb_shinfo(skb);
  1197  
> 1198          if (xfrm_offload(skb) && !ssi->gso_size)
  1199                  return adap->uld[CXGB4_ULD_CRYPTO].tx_handler(skb, dev);
  1200  
  1201          qidx = skb_get_queue_mapping(skb);
  1202          if (ptp_enabled) {
  1203                  spin_lock(&adap->ptp_lock);
  1204                  if (!(adap->ptp_tx_skb)) {
  1205                          skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;
  1206                          adap->ptp_tx_skb = skb_get(skb);
  1207                  } else {
  1208                          spin_unlock(&adap->ptp_lock);
  1209                          goto out_free;
  1210                  }
  1211                  q = &adap->sge.ptptxq;
  1212          } else {
  1213                  q = &adap->sge.ethtxq[qidx + pi->first_qset];
  1214          }
  1215          skb_tx_timestamp(skb);
  1216  
  1217          cxgb4_reclaim_completed_tx(adap, &q->q, true);
  1218          cntrl = TXPKT_L4CSUM_DIS_F | TXPKT_IPCSUM_DIS_F;
  1219  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to