Le 2018-03-06 10:32, James Hogan a écrit :
On Mon, Sep 18, 2017 at 07:32:40PM +0530, PrasannaKumar Muralidharan wrote:
Add RNG node to jz4780 dtsi. This driver uses registers that are part of the register set used by Ingenic CGU driver. Use regmap in RNG driver to access its register. Create 'simple-bus' node, make CGU and RNG node as
child of it so that both the nodes are visible without changing CGU
driver code.

Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com>

Better late than never:
Acked-by: James Hogan <jho...@kernel.org>

(I presume its okay for the reg ranges to overlap, ISTR that being an
issue a few years ago, but maybe thats fixed now).


What bothers me is that the CGU code has not been modified to use regmap, so the registers area is actually mapped twice (once in the CGU driver, once with regmap).

Besides, regmap would be useful if the RNG registers were actually located in the middle of the register area used by the CGU driver, which is not the case here. The CGU block does have some registers after the RNG ones on the X1000 SoC, but I don't think they will ever be used (and if they are it won't be by the CGU driver).


Reply via email to