On Thu, Sep 05, 2019 at 01:55:54PM +0000, Pascal Van Leeuwen wrote:
>
> > > index e12a2a3..0f1a9dc 100644
> > > --- a/drivers/crypto/inside-secure/safexcel.c
> > > +++ b/drivers/crypto/inside-secure/safexcel.c
> > > @@ -1503,7 +1503,9 @@ void safexcel_pci_remove(struct pci_dev *pdev)
> > >
> > > static int __init safexcel_init(void)
> > > {
> > > +#if IS_ENABLED(CONFIG_PCI)
> > > int rc;
> > > +#endif
> > >
> > > #if IS_ENABLED(CONFIG_OF)
> > > /* Register platform driver */
> >
> > Shouldn't you check for errors for CONFIG_OF too?
>
> You are correct, the platform_driver_register can also return an error
> code. So just fixing the compile warning was a bit short-sighted on my
> behalf.
>
> I'll redo that patch.
While you're at it, please fix the strange indentation in that
function too.
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
