On Tue, Oct 20, 2020 at 04:39:52PM -0400, Arvind Sankar wrote: > Without the barrier_data() inside memzero_explicit(), the compiler may > optimize away the state-clearing if it can tell that the state is not > used afterwards. At least in lib/crypto/sha256.c:__sha256_final(), the > function can get inlined into sha256(), in which case the memset is > optimized away. > > Signed-off-by: Arvind Sankar <nived...@alum.mit.edu>
Reviewed-by: Eric Biggers <ebigg...@google.com> Maybe get the one in arch/arm64/crypto/sha3-ce-glue.c too? - Eric
