On Mon, Feb 22, 2021 at 04:12:13PM +0100, Romain Perier wrote:
>
> diff --git a/crypto/lrw.c b/crypto/lrw.c
> index bcf09fbc750a..4d35f4439012 100644
> --- a/crypto/lrw.c
> +++ b/crypto/lrw.c
> @@ -357,10 +357,10 @@ static int lrw_create(struct crypto_template *tmpl, 
> struct rtattr **tb)
>        * cipher name.
>        */
>       if (!strncmp(cipher_name, "ecb(", 4)) {
> -             unsigned len;
> +             ssize_t len;
>  
> -             len = strlcpy(ecb_name, cipher_name + 4, sizeof(ecb_name));
> -             if (len < 2 || len >= sizeof(ecb_name))
> +             len = strscpy(ecb_name, cipher_name + 4, sizeof(ecb_name));
> +             if (len == -E2BIG || len < 2)

len == -E2BIG is superfluous as len < 2 will catch it anyway.

Thanks,
-- 
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Reply via email to