On Thu, Jul 03, 2025 at 07:19:34PM +0200, Thorsten Blum wrote:
> Replace the deprecated zero-length array with a modern flexible array
> member in the struct zstd_ctx.
Oh, weird. This is a very recent change. This should include:
Fixes: f5ad93ffb541 ("crypto: zstd - convert to acomp")
>
> No functional changes intended.
>
> Link: https://github.com/KSPP/linux/issues/78
> Signed-off-by: Thorsten Blum <thorsten.b...@linux.dev>
> ---
> crypto/zstd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/zstd.c b/crypto/zstd.c
> index 657e0cf7b952..c489976c3e8b 100644
> --- a/crypto/zstd.c
> +++ b/crypto/zstd.c
> @@ -25,7 +25,7 @@ struct zstd_ctx {
> zstd_dctx *dctx;
> size_t wksp_size;
> zstd_parameters params;
> - u8 wksp[0] __aligned(8);
> + u8 wksp[] __aligned(8);
And likely, to use __counted_by(wksp_size)
I'm surprised checkpatch.pl didn't warn, but I guess the __aligned
confused the script?
Reviewed-by: Kees Cook <k...@kernel.org>
-Kees
> };
>
> static DEFINE_MUTEX(zstd_stream_lock);
> --
> 2.50.0
>
>
--
Kees Cook
