Hi Jon, On Tue, Jan 6, 2026 at 10:40 AM Jon Hunter <[email protected]> wrote: > > Hi Uwe, > > On 15/12/2025 14:16, Uwe Kleine-König wrote: > > Hello, > > > > the objective of this series is to make tee driver stop using callbacks > > in struct device_driver. These were superseded by bus methods in 2006 > > (commit 594c8281f905 ("[PATCH] Add bus_type probe, remove, shutdown > > methods.")) but nobody cared to convert all subsystems accordingly. > > > > Here the tee drivers are converted. The first commit is somewhat > > unrelated, but simplifies the conversion (and the drivers). It > > introduces driver registration helpers that care about setting the bus > > and owner. (The latter is missing in all drivers, so by using these > > helpers the drivers become more correct.) > > > > v1 of this series is available at > > https://lore.kernel.org/all/[email protected] > > > > Changes since v1: > > > > - rebase to v6.19-rc1 (no conflicts) > > - add tags received so far > > - fix whitespace issues pointed out by Sumit Garg > > - fix shutdown callback to shutdown and not remove > > > > As already noted in v1's cover letter, this series should go in during a > > single merge window as there are runtime warnings when the series is > > only applied partially. Sumit Garg suggested to apply the whole series > > via Jens Wiklander's tree. > > If this is done the dependencies in this series are honored, in case the > > plan changes: Patches #4 - #17 depend on the first two. > > > > Note this series is only build tested. > > > > Uwe Kleine-König (17): > > tee: Add some helpers to reduce boilerplate for tee client drivers > > tee: Add probe, remove and shutdown bus callbacks to tee_client_driver > > tee: Adapt documentation to cover recent additions > > hwrng: optee - Make use of module_tee_client_driver() > > hwrng: optee - Make use of tee bus methods > > rtc: optee: Migrate to use tee specific driver registration function > > rtc: optee: Make use of tee bus methods > > efi: stmm: Make use of module_tee_client_driver() > > efi: stmm: Make use of tee bus methods > > firmware: arm_scmi: optee: Make use of module_tee_client_driver() > > firmware: arm_scmi: Make use of tee bus methods > > firmware: tee_bnxt: Make use of module_tee_client_driver() > > firmware: tee_bnxt: Make use of tee bus methods > > KEYS: trusted: Migrate to use tee specific driver registration > > function > > KEYS: trusted: Make use of tee bus methods > > tpm/tpm_ftpm_tee: Make use of tee specific driver registration > > tpm/tpm_ftpm_tee: Make use of tee bus methods > > > On the next-20260105 I am seeing the following warnings ... > > WARNING KERN Driver 'optee-rng' needs updating - please use bus_type methods > WARNING KERN Driver 'scmi-optee' needs updating - please use bus_type > methods > WARNING KERN Driver 'tee_bnxt_fw' needs updating - please use bus_type > methods > > I bisected the first warning and this point to the following > commit ... > > # first bad commit: [a707eda330b932bcf698be9460e54e2f389e24b7] tee: Add some > helpers to reduce boilerplate for tee client drivers > > I have not bisected the others, but guess they are related > to this series. Do you observe the same?
Yes, I see the same. I'm sorry, I didn't realize that someone might bisect this when I took only a few of the patches into next. I've applied all the patches in this series now. Thanks, Jens
