Hi, On Fri, Mar 23, 2018 at 1:21 PM, Karthikeyan Ramasubramanian <[email protected]> wrote: > + i2c10: i2c@a88000 { > + compatible = "qcom,geni-i2c"; > + reg = <0xa88000 0x4000>; > + clock-names = "se"; > + clocks = <&gcc GCC_QUPV3_WRAP1_S2_CLK>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&qup_i2c10_default>; > + pinctrl-1 = <&qup_i2c10_sleep>; > + interrupts = <GIC_SPI 355 > IRQ_TYPE_LEVEL_HIGH>; > + clock-frequency = <400000>;
Please move the clock-frequency to the board file. Not all devices on all boards will support 400 kHz, so we should be at 100 kHz by default and boards should explicitly say that they support 400 kHz. Other than that things look good to me and you can add my Reviewed-by tag. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
