> > +#ifdef __x86_64__ > > +#define X86_CR4_FRED_BIT 32 /* enable FRED kernel entry */ > > +#define X86_CR4_FRED _BITUL(X86_CR4_FRED_BIT) > > nit: s/BITUL/BITULL I guess if __x86_64__ is defined then we are > guaranteed that unsigned long will be a 64 bit, but for the sake of > clarity I'd rather have this spelled out explicitly by using BITULL >
UL is better because CR4 is a machine word. > > > > +#else > > +#define X86_CR4_FRED (0) > > +#endif
