On Tue, 9 Sep 2025 19:52:21 +0530 Anwar, Md Danish wrote:
> > +   for (i = 0; i < size_in_words; i++)
> > +           msg[i] = mbx_data_rd32(mbx, MUCSE_MBX_FWPF_SHM + 4 * i);  
> 
> The array indexing calculation should use multiplication by sizeof(u32)
> instead of hardcoded 4.

Not sure this is really necessary, I'd expect C programmers to intuit 
that 4 is the number of bytes in u32 here. sizeof(u32) is going to
overflow 80 char line limit and cause more harm than good.

Reply via email to