Badly initialized pointers with __free attr can
cause cleanup issues. So,
Adding checks for
- uninitialized pointers
- initialized pointers with NULL
Testing:
ran checkpatch.pl before and after the change on
crypto/asymmetric_keys/x509_public_key.c, which has
both initialized with NULL and uninitialized pointers
---
Changes in v2:
- change cover letter and title to reflect new changes
- fix regex to handle multiple declarations in a single line case
- convert WARN to ERROR for uninitialized pointers
- add a new WARN for pointers initialized with NULL
- NOTE: tried handling multiple declarations on a single line by splitting
them and matching the parts with regex, but, it turned out to be
complex and overkill. Moreover, multi-line declarations pose a threat
- Link to v1:
https://lore.kernel.org/r/20251021-aheev-checkpatch-uninitialized-free-v1-1-18fb01bc6...@gmail.com
---
Ally Heev (2):
checkpatch: add uninitialized pointer with __free attribute check
add check for pointers with __free attribute initialized to NULL
Documentation/dev-tools/checkpatch.rst | 11 +++++++++++
scripts/checkpatch.pl | 13 +++++++++++++
2 files changed, 24 insertions(+)
---
base-commit: 6548d364a3e850326831799d7e3ea2d7bb97ba08
change-id: 20251021-aheev-checkpatch-uninitialized-free-5c39f75e10a1
Best regards,
--
Ally Heev <[email protected]>
