On Fri, Oct 24, 2025 at 10:59:16PM +0530, Ally Heev wrote: > pointers with __free attribute initialized to NULL > pose potential cleanup issues [1] when a function uses > interdependent variables with cleanup attributes > > Link: https://docs.kernel.org/core-api/cleanup.html [1] > Link: > https://lore.kernel.org/all/[email protected]/ > Suggested-by: Dan Williams <[email protected]> > Signed-off-by: Ally Heev <[email protected]> > ---
I don't think this patch is a good idea... There are two issues to consider 1) The absolute number over warnings. 500+ is too high. 2) The ratio of bugs to false positives and we don't have any data on that but I bet it's low. It needs to be at least 5%. For anything lower than that, you're better off just reviewing code at random instead of looking through warnings. regards, dan carpenter
