> -----Original Message----- > From: Michael S. Tsirkin <[email protected]> > Sent: Sunday, February 1, 2026 10:05 AM > To: Chia-Yu Chang (Nokia) <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; Koen De Schepper (Nokia) > <[email protected]>; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected] > Subject: Re: [PATCH v1 net-next 2/3] net: hns3/mlx5e: avoid corrupting CWR > flag when receiving GRO packet > > > CAUTION: This is an external email. Please be very careful when clicking > links or opening attachments. See the URL nok.it/ext for additional > information. > > > > On Sat, Jan 31, 2026 at 11:55:09PM +0100, [email protected] > wrote: > > From: Chia-Yu Chang <[email protected]> > > > > In Accurate ECN, ACE counter (AE, ECE, CWR flags) changes only when > > new CE packets arrive, while setting SKB_GSO_TCP_ECN in case of not > > knowing the ECN variant can result in header change that corrupts the ACE > > field. > > The new flag SKB_GSO_TCP_ACCECN is to prevent SKB_GSO_TCP_ECN or > > NETIF_F_TSO_ECN offloading to be used because they would corrupt CWR > > flag somewhere. > > > > Signed-off-by: Chia-Yu Chang <[email protected]> > > Not my driver, but a better format is something along the lines of: > > Currently .... this is wrong because ... as the result .... fix this by ... > so that .... > > the coding style does say that you should use the imperative form. > Hi Michael,
I will update the commit messages for all these 3 patches. And sorry for the typo, this shall be v2, and the next version will be v3 - will clarify it. Thanks. Chia-Yu
